Skip to content

Conversation

6543
Copy link
Member

@6543 6543 commented May 27, 2021

Bildschirmfoto zu 2021-05-27 23-35-19

PS: codeberg emoji is only added for test purposes ...

fix #16060

@6543 6543 added the status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR label May 27, 2021
@silverwind
Copy link
Member

silverwind commented May 27, 2021

Also needs to be added at https://github.com/go-gitea/gitea/blob/main/web_src/js/features/emoji.js#L5 and https://github.com/go-gitea/gitea/blob/main/web_src/js/features/emoji.js#L26 and maybe more places.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2021
@silverwind
Copy link
Member

silverwind commented May 28, 2021

Generally I think this has no place here but we could make it easy to configure additional emojis, e.g. a map in the config that maps emoji name to a png/svg image URL, maybe even accepted as base64 data url which may be suitable for small svgs. Btw we need to change gitea emoji to svg :)

@6543
Copy link
Member Author

6543 commented Jun 1, 2021

I'll test it with codeberg emoji fist & make it configurable to finish the pull :)

@6543 6543 force-pushed the add-emoji-codeberg branch from ad9aedd to 3c82f01 Compare June 1, 2021 21:14
@6543 6543 changed the title Add "codeberg" emoji WIP: Add custom emoji support Jun 1, 2021
@6543 6543 added type/enhancement An improvement of existing functionality pr/wip This PR is not ready for review labels Jun 1, 2021
@6543 6543 added this to the 1.16.0 milestone Jun 18, 2021
@6543 6543 changed the title WIP: Add custom emoji support Add custom emoji support Jun 29, 2021
@6543 6543 removed status/blocked This PR cannot be merged yet, i.e. because it depends on another unmerged PR pr/wip This PR is not ready for review labels Jun 29, 2021
@6543 6543 added the type/bug label Jun 29, 2021
@6543 6543 force-pushed the add-emoji-codeberg branch from db64977 to 4e2c217 Compare June 29, 2021 01:44
@6543 6543 requested a review from silverwind June 29, 2021 02:04
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2021

Codecov Report

Merging #16004 (71d3aa8) into main (aac663e) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16004      +/-   ##
==========================================
+ Coverage   45.40%   45.42%   +0.02%     
==========================================
  Files         709      709              
  Lines       83496    83500       +4     
==========================================
+ Hits        37913    37934      +21     
+ Misses      39501    39487      -14     
+ Partials     6082     6079       -3     
Impacted Files Coverage Δ
modules/markup/html.go 78.11% <100.00%> (-0.11%) ⬇️
modules/setting/setting.go 49.90% <100.00%> (+0.28%) ⬆️
modules/templates/helper.go 50.00% <100.00%> (+0.25%) ⬆️
routers/api/v1/settings/settings.go 100.00% <100.00%> (ø)
modules/log/event.go 59.90% <0.00%> (-1.89%) ⬇️
models/repo_list.go 77.04% <0.00%> (-0.78%) ⬇️
services/pull/patch.go 55.93% <0.00%> (+1.69%) ⬆️
modules/queue/workerpool.go 54.96% <0.00%> (+1.90%) ⬆️
models/unit.go 43.83% <0.00%> (+2.73%) ⬆️
services/pull/check.go 28.27% <0.00%> (+2.75%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac663e...71d3aa8. Read the comment docs.

@6543 6543 modified the milestones: 1.16.0, 1.15.0 Jun 29, 2021
@6543
Copy link
Member Author

6543 commented Jun 29, 2021

moved because it's a bugfix too

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 29, 2021
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2021
@6543 6543 merged commit 6554835 into go-gitea:main Jun 29, 2021
@6543 6543 deleted the add-emoji-codeberg branch June 29, 2021 14:28
@6543
Copy link
Member Author

6543 commented Jun 29, 2021

ok for those looking at codeberg emoji -> #16296

AbdulrhmnGhanem pushed a commit to kitspace/gitea that referenced this pull request Aug 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to display characters :1: in Markdown documents
6 participants