-
-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Add custom emoji support #16004
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom emoji support #16004
Conversation
Also needs to be added at https://github.com/go-gitea/gitea/blob/main/web_src/js/features/emoji.js#L5 and https://github.com/go-gitea/gitea/blob/main/web_src/js/features/emoji.js#L26 and maybe more places. |
Generally I think this has no place here but we could make it easy to configure additional emojis, e.g. a map in the config that maps emoji name to a png/svg image URL, maybe even accepted as base64 data url which may be suitable for small svgs. Btw we need to change gitea emoji to svg :) |
I'll test it with codeberg emoji fist & make it configurable to finish the pull :) |
Codecov Report
@@ Coverage Diff @@
## main #16004 +/- ##
==========================================
+ Coverage 45.40% 45.42% +0.02%
==========================================
Files 709 709
Lines 83496 83500 +4
==========================================
+ Hits 37913 37934 +21
+ Misses 39501 39487 -14
+ Partials 6082 6079 -3
Continue to review full report at Codecov.
|
moved because it's a bugfix too |
Co-authored-by: zeripath <[email protected]>
ok for those looking at codeberg emoji -> #16296 |
PS: codeberg emoji is only added for test purposes ...
fix #16060